Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing jsonc comments from generated JSON #36

Closed
sveinse opened this issue Sep 5, 2024 · 0 comments · Fixed by #38
Closed

Missing jsonc comments from generated JSON #36

sveinse opened this issue Sep 5, 2024 · 0 comments · Fixed by #38

Comments

@sveinse
Copy link
Member

sveinse commented Sep 5, 2024

odg now omits comments on certain variable in JSON format. This used to work in odg3.4 and are not working in odg3.5

    {
      "index": "0x1003",  // 4099
      "name": "Pre-defined Error Field",
      "struct": "array",
      "group": "built-in",
      "mandatory": false,
      "profile_callback": true,
      "each": {
        "name": "Standard Error Field",
        "type": "UNSIGNED32",  // 7   <-- This is missing in odg3.5
        "access": "ro",
        "pdo": false,
        "nbmin": 1,
        "nbmax": 254
      },
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant