Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to schema file #37

Closed
landrak opened this issue Sep 5, 2024 · 3 comments · Fixed by #43
Closed

Add reference to schema file #37

landrak opened this issue Sep 5, 2024 · 3 comments · Fixed by #43

Comments

@landrak
Copy link

landrak commented Sep 5, 2024

Add property "$schema" with a reference to the file https://github.com/Laerdal/python-objdictgen/blob/main/src/objdictgen/schema/od.schema.json to the *.json file format. This will help JSON tools and editors to validate and edit file files.

@sveinse
Copy link
Member

sveinse commented Sep 5, 2024

https://www.schemastore.org/json/ could be a way to to it publicly. To do we need to commit the objdictgen schema as a PR to https://github.com/SchemaStore/schemastore

@sveinse
Copy link
Member

sveinse commented Sep 11, 2024

According to1 the $schema field refers to the schema of the schema-file while $id contain the reference to the format which is describes2. This is the current implementation and the $id reference is valid.

Footnotes

  1. https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-00#rfc.section.8.1.1

  2. https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-00#rfc.section.8.2.1

@sveinse sveinse closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2024
@sveinse
Copy link
Member

sveinse commented Sep 11, 2024

The schema file is properly annotated, but the OD files are not linked to the schema. Reopening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants