Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light doesn't go away when a light source isn't held or picked up. #47

Closed
LorneTheine opened this issue Jan 18, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@LorneTheine
Copy link

LorneTheine commented Jan 18, 2021

Describe the bug
Light doesn't go away and sticks to its last position when a light source is either not held or when it's picked up.

To Reproduce
No steps to reproduce the bug, it just suddenly happened. Even when restarting Minecraft, the bug is still there.

Video

Desktop:

  • OS: Windows 10 Home
  • Minecraft 1.16.5
  • Fabric Loader version [0.11.1-1.16.5]
  • Mods:
    • DynamicSoundFilters-1.1.3+1.16.2
    • fabric-api-0.29.3+1.16
    • lambdynamiclights-fabric-1.3.3+1.16
    • logical_zoom-0.0.7
    • Mambience-2.1.0+1.16.2
    • phosphor-fabric-mc1.16.4-0.6.0+build.7
    • sodium-fabric-mc1.16.4-0.1.0
  • Version [1.3.3]
  • Branch [mc1.16]

Additional PC Info (In case there's something important here)

  • CPU: Intel Core i3-2350M @ 2.30GHz
  • GPU: Intel HD Graphics 3000
  • OpenGL Version: 3.1.0
  • DirectX Version: 10.1
  • RAM: 6gb

Sorry if there are miscommunications, English isn't my native language.

@LorneTheine LorneTheine added the bug Something isn't working label Jan 18, 2021
@F1rz-L
Copy link

F1rz-L commented Jan 18, 2021

this happens for me too, basically the light doesnt go away after a "dynamic light item" picked up or isnt held anymore. This only happens for me in this update.

@LambdAurora
Copy link
Owner

Fixed in version 1.3.4.

The bug was caused by the fact that ChunkSectionPos and BlockPos packing methods are not the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants