-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Recipes a package? #18
Comments
I think it would be a good idea. It's mainly useful for Perhaps the namespace should be |
Last time I checked, setuptools didn't allow to have top-level and subpackage to be different projects. So you can have two software projects with packages called Names that I can think of that would work:
|
Seems a bit arrogant maybe to hijack 'recipes' for this? I don't know :) It would be the most convenient option I suppose. |
|
Do we need it on PyPI at all? I guess the intended usage is to clone the github repository, and then just optionally install it from there to make it easier to use some parts for temporary experimentation? Or do we actually plan to turn it into a package that people can put in their
If @ebattenberg doesn't plan to publish his own add-ons :) |
Yeah I don't suppose this is really PyPI material. Especially because it's largely untested and undocumented. |
Also because it's supposed to grow continuously, and we probably don't want to make releases every now and then for no particular reason. People can either use parts of it by copy/paste (I guess that'd be the most common use case), or they can put a git commit in their So... yes, let's turn it into a package, but not register on PyPI, so just call it |
I don't know, it might be confusing if half of the repository content is in the top-level and half of it is in the |
I agree with all of this.
How about keeping It would be nice if they could be in the |
Yes, that's also an option -- having two top-level directories that can be installed, and the others for free exploration. We're polluting the user's namespace a bit then (with both |
As discussed in #16, it might be nice to make this repo (or a subset) into a package, so that things like pretrained models can be imported into users code.
Anyone have arguments against? Or feel like making a PR?
The text was updated successfully, but these errors were encountered: