Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compiled flip implementations #327

Open
10 of 11 tasks
Latios96 opened this issue Apr 16, 2024 · 0 comments
Open
10 of 11 tasks

Use compiled flip implementations #327

Latios96 opened this issue Apr 16, 2024 · 0 comments
Assignees
@Latios96
Labels
enhancement New feature or request

Comments

@Latios96
Copy link
Owner

Latios96 commented Apr 16, 2024 •
edited
Loading

Since flip is available on PyPi via pip install flip-evaluator, we should be able to integrate this easily.

  • rebase branch use-compiled-flip onto main
  • adapt to newest versions, amend commit
  • measure time savings

Old Tasks:

  • investigate flip comparison for exrs with extra channels #341
  • report bug with multiple flip calls
  • create repo to build python wheels and upload them as releases
  • patch flip to output error messages in the form "Reference and Test image resolutions differ. Reference image is 100x200px, output image is 100x100px"
  • add flip as dependency
  • use compiled flip for image comparison
  • measure time savings (5,9s vs 30s for ExampleSpheres)
  • try to upstream patch
@Latios96 Latios96 added the enhancement New feature or request label Apr 16, 2024
@Latios96 Latios96 self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Latios96 Latios96

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Latios96