Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with icons applying #951

Closed
Vijorich opened this issue Jan 5, 2023 · 20 comments
Closed

Problem with icons applying #951

Vijorich opened this issue Jan 5, 2023 · 20 comments

Comments

@Vijorich
Copy link
Contributor

Vijorich commented Jan 5, 2023

About this discussion

Why do some icons not change even though they are in the icon pack and all links are correct?

video_2023-01-05_21-20-22.mp4
@Vijorich
Copy link
Contributor Author

Vijorich commented Jan 6, 2023

  • Steam (com.valvesoftware.android.steam.community)
  • Xtra (com.github.andreyasadchy.xtra)
  • Goodline (info.goodline.mobile2)
  • FixPrice (ru.bestprice.fixprice)
  • Grill one (ru.geo.ppmobile.grillone)
  • Eapteka (ru.getpharma.eapteka)
  • Paysphere (ru.nskes.paysphera)
  • SGK (ru.sibgenco.general)
  • Riseup VPN (se.leap.riseupvpn)
  • Mind Tracker (com.fedosov.mindtracker)
    These icons do not apply properly

@jacksonwelsh
Copy link

+1, 1password 8 as well. com.1password.android

@Vijorich Vijorich changed the title [DISCUSSION] Problem with icons applying Problem with icons applying Jan 25, 2023
@naveenccmsd
Copy link
Contributor

@Vijorich Can you share the app component details for the above apps to verify?

you can follow below guid to get it.
https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#using-3rd-party-apps

or below

WhatsApp.Video.2023-01-27.at.2.51.21.AM.mp4

@jacksonwelsh
Copy link

For 1password:

<appfilter>

	<!-- 1Password -->
	<item component="ComponentInfo{com.onepassword.android/com.onepassword.android.app.StartActivity}" drawable="1password"/>

</appfilter>

@naveenccmsd
Copy link
Contributor

@jacksonwelsh , Thank you . I have added link for 1password.

#1002

@Vijorich
Copy link
Contributor Author

@Vijorich Can you share the app component details for the above apps to verify?

you can follow below guid to get it.
https://github.com/LawnchairLauncher/lawnicons/blob/develop/CONTRIBUTING.md#using-3rd-party-apps

or below

WhatsApp.Video.2023-01-27.at.2.51.21.AM.mp4

https://paste.crdroid.net/l4CdeH

VID_20230128_232132_243.mp4

@naveenccmsd
Copy link
Contributor

@Vijorich I undersnad you were facing issue with icon request app , unfortuanitly it was not owned by lawncher team, we can't fix the issue , without appcomponent details from your mobile we can't fix the icon mapping issue.

Can you try with any other apps and extract the app componenet details ? it should be something like below

<!-- 1Password -->
<item component="ComponentInfo{com.onepassword.android/com.onepassword.android.app.StartActivity}" drawable="1password"/>

Alernativy try the below app and select iconsrequest option

https://github.com/naveenccmsd/Ayan/releases/download/1.2.2/Ayan_iconpack_v1.2.2.apk or candybar dev in from playstore

@Vijorich
Copy link
Contributor Author

Vijorich commented Feb 17, 2023

@naveenccmsd
Steam (com.valvesoftware.android.steam.community/com.valvesoftware.android.steam.community.MainActivity) Steam.svg
Goodline (info.goodline.mobile2/info.goodline.mobile2.MainActivity) goodline.svg
FixPrice (ru.bestprice.fixprice/ru.bestprice.fixprice.application.root.MainActivity) FixPrice.svg
Grill one (ru.geo.ppmobile.grillone/ru.geo.ppmobile.grillone.MainActivity) grillone.svg
Eapteka (ru.getpharma.eapteka/ru.getpharma.eapteka.mainscreen.bottom_navigation.MainActivityWithBottomBar) eapteka.svg
Paysphere (ru.nskes.paysphera/ru.nskes.paysphera.presentation_v2.screen.activity.main_activity.MainActivity) paysphera.svg
SGK (ru.sibgenco.general/ru.sibgenco.general.ui.activity.HomeActivity) skg.svg
Riseup VPN (se.leap.riseupvpn/se.leap.bitmaskclient.base.MainActivity) riseup_vpn.svg
Mind Tracker (com.fedosov.mindtracker/com.fedosov.mindtracker.MainActivity) mindtracker.svg
RuStore (ru.vk.store/ru.vk.store.app.MainActivity) rustore.svg
Pyaterochka (ru.pyaterochka.app.browser/ru.pyaterochka.app.browser.BrowserActivity) pyaterochka.svg
Sber mega market (ru.goods.marketplace/ru.goods.marketplace.SingleActivity) sber_mega_market.svg

@Chefski
Copy link
Member

Chefski commented Mar 12, 2023

@Vijorich could you check if all the icons are working as intended now with the latest debug file?

@Vijorich
Copy link
Contributor Author

@Chefski
Screenshot_20230313-045131_Sushi Launcher.png

3/12

@daywalk3r666
Copy link
Contributor

Screenshot_20230313-072335_Lawnchair (Debug)

6/9

I will check if the activities are right and the right drawable are linked

@daywalk3r666
Copy link
Contributor

daywalk3r666 commented Mar 13, 2023

Screenshot_20230313-081947_Lawnchair (Debug)
Test it with this version of lawnchair LawnchairLauncher/lawnchair@44da9e2
If my pull request won't work for you. Try to delete app data, maybe deleting cache is enough?

Works with kvaesitso launcher too.

@daywalk3r666
Copy link
Contributor

@Vijorich can you check the last debug apk

@Vijorich
Copy link
Contributor Author

Vijorich commented Mar 14, 2023

@daywalk3r666
Still only 3 of 12 for me in both lawnicons and kvaesitoScreenshot_20230314-081131_Sushi Launcher.png

Screenshot_20230314-081117_Sushi Launcher.png

Screenshot_20230314-081134_Sushi Launcher.png

Screenshot_20230314-081120_Sushi Launcher.png

@daywalk3r666
Copy link
Contributor

whats your current lawnchair version? because since lawnicons switched to an icon pack, my app won't work with lawnchair launcher.

@Vijorich
Copy link
Contributor Author

whats your current lawnchair version? because since lawnicons switched to an icon pack, my app won't work with lawnchair launcher.

Screenshot_20230314-123825_Sushi Launcher.png

I have sushi launcher, which was pre installed in rom

@daywalk3r666
Copy link
Contributor

Then is launcher rated?

@KTibow
Copy link
Contributor

KTibow commented Aug 9, 2023

Perhaps a caching issue? Does this happen with a different launcher?

@PathosEthosLogos
Copy link

Perhaps a caching issue? Does this happen with a different launcher?

Does not seem to do it. I also tried clearing Lawnchair cache (though not Lawnicons).

Seems to be a well-known problem #1154 #1722

Is this a Lawnchair issue?

Secure Folder and muPDF are not applying for me.

@x9136
Copy link
Collaborator

x9136 commented Apr 23, 2024

I suggest installing Lawnchair 14 Beta 2, the latest version of Lawnicons, and let us know if the problem still occurs.

@x9136 x9136 closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants