Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The eigen_rpc_request_duration_seconds need change _seconds suffix of the metric name #333

Closed
fyInALT opened this issue Sep 4, 2024 · 1 comment · Fixed by #338
Closed

The eigen_rpc_request_duration_seconds need change _seconds suffix of the metric name #333

fyInALT opened this issue Sep 4, 2024 · 1 comment · Fixed by #338
Labels
bug Something isn't working

Comments

@fyInALT
Copy link
Contributor

fyInALT commented Sep 4, 2024

Describe the bug

Noticed that the eigen_rpc_request_duration_seconds histogram metric seems to record abnormal values - it looks like they are expressed in nanoseconds which contradicts the _second suffix of the metric name

Expected behavior

For this request duration, we need change it 's name.

Screenshots

OS details

Additional context
@fyInALT fyInALT added the bug Something isn't working label Sep 4, 2024
@samlaf
Copy link
Collaborator

samlaf commented Sep 4, 2024

I’d prefer to change the behavior and fix it to export seconds instead.

@renlulu renlulu mentioned this issue Sep 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rpc request duration in seconds renlulu/eigensdk-go
2 participants
@samlaf @fyInALT