You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The functions in the signerv2 (for eg this) return bind.SignerFn instead of SignerFn, which is confusing because the txMgr needs a SignerFn. So the user either has to wrap the bind.SignerFn themselves, or use the more complicated (and also confusing) signerFromConfig. This one is confusing because forcing user to use the config which has too many fields and unclear which ones are mandatory and which ones are not.
I think we should just make the simple constructors return SignerFn directly, and then the SignerFromConfig can just call those and return directly, instead of wrapping their returned bind.SignerFn in a SignerFn.
The text was updated successfully, but these errors were encountered:
@shrimalmadhur what's the state of this? Also why do we still have signer around? Is that just for backwards compatibility? Is it still relevant to anything/anyone?
The functions in the signerv2 (for eg this) return
bind.SignerFn
instead ofSignerFn
, which is confusing because the txMgr needs aSignerFn
. So the user either has to wrap thebind.SignerFn
themselves, or use the more complicated (and also confusing) signerFromConfig. This one is confusing because forcing user to use the config which has too many fields and unclear which ones are mandatory and which ones are not.I think we should just make the simple constructors return
SignerFn
directly, and then the SignerFromConfig can just call those and return directly, instead of wrapping their returnedbind.SignerFn
in aSignerFn
.The text was updated successfully, but these errors were encountered: