Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how can I set fixed trim slider for min and max duration of length. Also trim slider can not move forward or backward #42

Closed
ViruRock opened this issue Oct 23, 2021 · 6 comments · Fixed by #126
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ViruRock
Copy link

ViruRock commented Oct 23, 2021

how can I set fixed trim slider for min and max duration of length.
Also trim slider can not move forward or backward

@LeGoffMael
Copy link
Owner

You can check the example to set up a max duration

@override
  void initState() {
    _controller = VideoEditorController.file(widget.file,
        maxDuration: Duration(seconds: 30))
      ..initialize().then((_) => setState(() {}));
    super.initState();
  }

min duration is however not supported yet

@LeGoffMael LeGoffMael added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 12, 2022
@GelidGeorge
Copy link

Could you add a feature where minDuration could be set...

@GelidGeorge
Copy link

Currently I am displaying a message to trim for 15 seconds...
It would be nice if user cannot go less than 15 seconds mark or the desired mark...

@GelidGeorge
Copy link

GelidGeorge commented May 18, 2022

after upgrading to flutter v3 I am getting some warnings

Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
../…/cover/cover_viewer.dart:114

  • 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../Development/flutter_sdk/packages/flutter/lib/src/widgets/binding.dart').
    package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance!

it would be helpful if you could address this ASAP

@LeGoffMael
Copy link
Owner

LeGoffMael commented May 22, 2022

@GelidGeorge V1.4.2 is available with flutter 3 update to remove the warnings

I probably won't have time to work on a new feature in the next couple of weeks. But If you really need it you can submit a PR that I will be happy to review

@LeGoffMael
Copy link
Owner

minDuration is now supported in v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants