Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Browser Support #837

Closed
alishahab opened this issue Feb 24, 2015 · 6 comments
Closed

Cross-Browser Support #837

alishahab opened this issue Feb 24, 2015 · 6 comments

Comments

@alishahab
Copy link

Please try to make it compatible with more then 1% usage browsers.

@ottuzzi
Copy link

ottuzzi commented Feb 24, 2015

Hi,

does not work with ie8: this is a perfectly sensible choice but, please, add a list of supported browser in readme :)

Thanks
Bye
Piero

@vlazar
Copy link
Collaborator

vlazar commented Feb 24, 2015

-1
Please don't. Let's move the web forward :)

@LeaVerou
Copy link
Owner

If someone wants to investigate the IE9 issue, and submit a fix, I’d be willing to consider it (assuming the fix isn't too horrible or more than a couple loc). But IE8 is out of the question.
It’s not just market share that matters, it’s also the trend. IE8 usage is dropping, fast. And autocomplete in most cases is a nice-to-have, not something that breaks the website if it’s not there.

@drifterz28
Copy link

I know this is closed but I wanted to add that this works just fine in IE9 when the scripts are moved before the closing body tag or it is wrapped in an onload event.

@LeaVerou
Copy link
Owner

Hmm interesting, thanks @drifterz28! Pull request? :)

@vlazar
Copy link
Collaborator

vlazar commented Mar 20, 2015

Which probably means the code waiting for DOM ready fails in IE9?
https://github.com/LeaVerou/awesomplete/blob/gh-pages/awesomplete.js#L365-L372

@LeaVerou I could probably fix it if only we have tests first ;)
How about one of the test frameworks and test runners mentioned in #14565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants