-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have uglifyjs spit out a sourcemap for leaflet.js too. #5351
Conversation
re my second commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @IvanSanchez do you have any comments on the extensions of the source maps before merging?
@perliedman As I said in #5341 I don't really see the usefulness, but if you and @danzel agree, then it's OK. |
@IvanSanchez ok, right. But the question was more about @danzel's last commit, and the actual file extension of the source map. It appears to have been just |
Ah, oh, ok 😄 According to the sourcemap spec:
So ideally I'd go for Let me double-check @danzel 's changes to the build scripts, I'm not sure this is what we have now. |
LGTM. |
in order to comply with source map spec https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit#heading=h.9ppdoan5f016 > Optionally, a source map will have the same name as the generated file but with a “.map” extension. For example, for “page.js” a source map named “page.js.map” would be generated. See also: Leaflet/Leaflet#5351
in order to comply with source map spec https://docs.google.com/document/d/1U1RGAehQwRypUTovF1KRlpiOFze0b-_2gc6fAH0KY0k/edit#heading=h.9ppdoan5f016 > Optionally, a source map will have the same name as the generated file but with a “.map” extension. For example, for “page.js” a source map named “page.js.map” would be generated. See also: Leaflet/Leaflet#5351
Fixes #5341
The resulting source map points back to the original files too 👍