Remove touch based click tolerance #5922
Conversation
|
|
||
| // @option tolerance: Number = 0 | ||
| // How much to extend click tolerance round a path/object on the map | ||
| tolerance : 0 |
There was a problem hiding this comment.
Shouldn't the default of this be Browser.touch ? 10 : 0?
There was a problem hiding this comment.
I think that we should try to build so little logic as possible round browser.touch in the library, because it's difficult to detect if it's a touch device or not. But still give the options for the users to be able to set tolerance. What do you think?
There was a problem hiding this comment.
Since I've supervised this PR, I think I will have to agree with @Muscot 😄
@IvanSanchez from a backwards compatibility point of view, you are right, but I think the old default does not make sense: SVG does not have the same (larger tolerance when touch is true), and actually setting the tolerance to anything other than 0 will cause problems with lines/polygons that are right next to each other (see #5144).
So, I'd argue actually defaulting to 0 is what we've always should have done.
There was a problem hiding this comment.
If @perliedman says it's right to break a bit of backwards compatibility, then I have no problem with that.
IvanSanchez
changed the title
Fixes #5921