-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon to webpage #4
Comments
I think I can help with this. Just to be sure I understand, you'd like that mustache image to be the favicon for the website? Would you like me to use that exact image or should I create one similar but more suited to the job of being a favicon? |
If another image is better to the limited resolution of the favicon, that's fine. I'm looking for something vaguely handlebar moustache-y there. |
I can't seem to clone your repository correctly. I think it's something to do with the fact that the repository leagify.github.io is a submodule in this repository and is called public. I can make the favicon file, but I'm not sure I'd be able to make a pull request to this repository. |
Yes true @TJScalzo |
That is unfortunate. Could you explain where this would fit in, if you were able to clone the repo? It looks like you've linked to the public output from the hugo command. |
I wonder if there's a way to add favicons through Hugo? The only way I know of is adding them manually. |
I think hugo might add them through the use of "partials". I remember that one theme used them, but a lot of themes do not. I'm going to include your other comment below for reference's sake:
|
That's exactly what I was just about to say! I found this and was about to post that it might solve the problem. |
Either way, I'm a ton closer to solving the issue than I was at the start. |
It seems like the theme you're using has a favicon partial template built into it that you can activate through what I'm assuming is the site's config file. I'm not sure how useful that is since it only allows for a single file, but it can be a point to start from. |
If I add an icon to
It looks like this support was added recently (theNewDynamic/gohugo-theme-ananke#54) |
I don't know if I explained or not, but the files I added are so the site will have a nice favicon on all OSs. If you're fine with focusing on just the main favicon for right now, you'd want to use "favicons/favicon.ico". The one you've picked is specifically for if the website is used on an iPhone or iPad. |
Let me know if you run into any other problems. |
I think that did the trick. Thanks, @TJScalzo ! 🥇 |
@MaanavD I see an alpha background there, are the edges visible on a black background? If so, it does look cool. |
You're right. That one is nice. |
I'd like to add an icon to the site. It'd be nice if the icon appears in the tab when you go to https://leagify.github.io/
Something like this would be nice:
The text was updated successfully, but these errors were encountered: