Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Don't await actor[rollMethod].call in default case (line 328 lmrtfy.js) #186

Open
tposney opened this issue Jun 3, 2023 · 0 comments

Comments

@tposney
Copy link

tposney commented Jun 3, 2023

Only in the default case is the roll awaited, this has the side effect of leaving the dialog open until the dice so nice 3d dice rolls complete. Also can you pass the lmrtfy flags data as options to the roll call - that would solve a timing issue I created where many messages get the same tag.

This has caused some confusion amongst users of my modules.
line 328 or lmrtfy.js

await  actor[rollMethod].call(actor, ...args, options) 

becomes

setProperty(options, "flags.lmrtfy", {"message": this.data.message, "data": this.data.attach})
actor[rollMethod].call(actor, ...args, options)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant