Skip to content
This repository has been archived by the owner on Sep 3, 2022. It is now read-only.

Put known hashes with unkown strings in additional fields #20

Open
LeagueSandboxBot opened this issue Dec 29, 2016 · 3 comments
Open

Put known hashes with unkown strings in additional fields #20

LeagueSandboxBot opened this issue Dec 29, 2016 · 3 comments

Comments

@LeagueSandboxBot
Copy link

Title


Beep, boop, I'm a bot! This issue was created by @moonshadow565 in #content-serializer.

@MythicManiac
Copy link
Member

MythicManiac commented Dec 29, 2016

Some clarification on this? @moonshadow565

@moonshadow565
Copy link
Member

Currently some hashes are missing but their values are enough self descriptive to be stored under proper key in serialized content.
They could be moved to third field (other than Values and UNKNOWN_HASHES).

@MythicManiac
Copy link
Member

MythicManiac commented Dec 29, 2016

You can add them to the conversion map, and update the conversion map later if we do find their proper value. That's what the content format version metadata is for in the end, as that can be used to migrate older versions to newer or the other way around. So add whatever hashes you have in mind to the conversion map and then bump the version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants