Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Props to pages to allow for dynamic title updates #91

Open
ryandotfurrer opened this issue Mar 23, 2024 · 3 comments
Open

Add Props to pages to allow for dynamic title updates #91

ryandotfurrer opened this issue Mar 23, 2024 · 3 comments
Assignees
@ryandotfurrer
Labels
🚀 Enhancement Suggesting improvements to existing features.

Comments

@ryandotfurrer
Copy link
Collaborator

Right now every page has the title "Deals for Devs." I propose using props and establishing said title per page, but so it updates the variable in the layout for the page Titles.

This is an example from my portfolio site so you can see how it might work.

On layout.tsx

interface Props {
  title: string;
  description: string;
}

<html lang="en">
	<meta property="og:title" content={title} />

On individual pages

const title = "Now";
@ryandotfurrer ryandotfurrer added the 🚀 Enhancement Suggesting improvements to existing features. label Mar 23, 2024
@ryandotfurrer
Copy link
Collaborator Author

@jamesqquick What are your thoughts on this? I'd like @chris-nowicki's thoughts as well since I spoke with him briefly on it.

@jamesqquick
Copy link
Collaborator

I think this is absolutely the way to go. @ryandotfurrer Are you ok to take this on?

@ryandotfurrer
Copy link
Collaborator Author

I think this is absolutely the way to go. @ryandotfurrer Are you ok to take this on?

Getting back to the development world and yes I'm happy to take it on.

@ryandotfurrer ryandotfurrer self-assigned this Apr 12, 2024
@ryandotfurrer ryandotfurrer moved this to In Progress in Deals for Devs Kanban Apr 12, 2024
@ryandotfurrer ryandotfurrer moved this from In Progress to Todo in Deals for Devs Kanban Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryandotfurrer ryandotfurrer

Labels
🚀 Enhancement Suggesting improvements to existing features.
Projects
Deals for Devs Kanban
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesqquick @ryandotfurrer