CircleCI: "Upload Packages" step fails, wheels are not published

[hacklschorsch]

Now that #65 is fixed the builds on master fail again, but now with a different problem (one example CircleCI run).
The "Upload Packages" step fails with:

Uploading distributions to https://test.pypi.org/legacy/
Uploading 
python_challenge_bypass_ristretto-2024.11.6.dev6-py2.py3-none-macosx_14_0_arm64.
whl
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 289.3/289.3 kB • 00:00 • 54.9 MB/s
WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         User 'exarkun' does not have two-factor authentication enabled. Please 
         enable two-factor authentication before attempting to upload to PyPI.  
         See https://test.pypi.org/help/#two-factor-authentication for more     
         information.                                                           

Exited with code exit status 1

[hacklschorsch]

Together with @btlogy we could login to PyPi and generate a new token for PyPI - but we don't have access to test.pypi.org yet (https://test.pypi.org/project/python-challenge-bypass-ristretto/) so we first need to get that from the only maintainer

[hacklschorsch]

@btlogy please create an account for publishing on test.PyPI.org and retrieving authorization for publishing for this project ❤️

[btlogy]

I've created the same la-it-ops user on test.pypi.org and I've re-opened LeastAuthority/it-ops#517 to finalize this missing bit...

[btlogy]

We should be back in business on test.pypy.org.

[btlogy]

I've triggered a re-run of the master branch on CircleCI...

Cc: @crwood @hacklschorsch

[btlogy]

All 🟢

[btlogy]

Wait: green but I do not see any new package released!?

[hacklschorsch]

Wait: green but I do not see any new package released!?

We still need to add new PyPI API credentials to the CI config, no?

[hacklschorsch]

I think this overview shows nicely what all didn't work:

https://github.com/LeastAuthority/python-challenge-bypass-ristretto/runs/33664282092

It looks to me like the name of that workflow doesn't fit so well - it is called 'all tests' yet most of it is about packaging and publishing. The tests report green and then all the publishing doesn't happen :/

[btlogy]

I think this overview shows nicely what all didn't work:

https://github.com/LeastAuthority/python-challenge-bypass-ristretto/runs/33664282092

That's from 2 weeks ago: I've re-run all jobs from the master branch yesterday and it was green.

[btlogy]

Wait: green but I do not see any new package released!?

We still need to add new PyPI API credentials to the CI config, no?

They are defined as env. var. in the project settings on CircleCI (always were, but rotated only yesterday).

But indeed, the job ends on a successful "Upload Packages" stating:

Package index credentials unavailable; skipping upload.

Ok, I've found the culprit: the variable name in the config differs from the code (only for the test):
TEST_TWINE_PASSWORD != TWINE_TESTPYPI_PASSWORD

I've fixed it. And re-run the job, but from the GitHub overview, just to see if the new result will show there too.

[btlogy]

The re-run button from GH does not seem to work.
But from CircleCI, it has work and the upload too.

There is now a new test release: v2024.11.6.dev6 is available.

Unless I'm missing something else, I think we're good to go.

[hacklschorsch]

Thanks! Great to have one part completed at least :)

[hacklschorsch]

Regarding deployment: I think we might want to wait with a proper "release" (i.e. making a tag on master) until we have made sure the current failing tests in zkapauthorizer are not due to a regression in python-challenge-bypass-ristretto