Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sender must check window before closing #109

Open
May-Lee opened this issue Dec 13, 2022 · 2 comments
Open

Sender must check window before closing #109

May-Lee opened this issue Dec 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@May-Lee
Copy link

May-Lee commented Dec 13, 2022

If I have a lot of tabs open, and have sent a number of files using Winden, then if I want to close any tabs, I need to check my windows to see if they have sent.

Some suggestions:

  • something like a favicon change/notification that would let me know it's okay to close my tab without having to check back at it
  • Have some sound and/or desktop notification
  • Have the sending in a pop up window that closes automatically when done
@donpui donpui added the enhancement New feature or request label Dec 13, 2022
@donpui
Copy link
Contributor

donpui commented Dec 13, 2022

I think reusing favicon icon as status would be nice improvement. Example here: https://www.npmjs.com/package/favicon-notification

Also we could identify several states: receiver accepted code, receiver rejected code, receiver is downloading, download completed.

@donpui
Copy link
Contributor

donpui commented Dec 22, 2022

@May-Lee there was some improvement with release https://github.com/LeastAuthority/winden/releases/tag/0.5.3-beta, which can help this issue. Now users gets warning if they try close browser while code is not accepted or transfer is going on. Please check and give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants