Confusing property editors

[kows]

Hi there,

would it be possible to give some kind of indication that the editors included in this package are part of LeBlender?
It is quite confusing they show up in Umbraco's "Create datatype" dropdown list (where they never should be selected afaik) with no clear link to LeBlender.
This for rte, image, macro, embed and textstring.
LeBlender Editor even loads some stuff in there and gives weird behavior.

Preferably name or alias mentions LeBlender.

[soreng]

hi @kows

LeBlender does not include any editors. It creates a "tree" that is displayed under the "developer"-section in umbraco, and allows editing of the editors that are either in the config/grid.editors.config.js or individual package.manifest-files found in plugins. It also allows for creating editors (stored in config/grid.editors.config.js) by picking one or more datatypes.

If you feel the editors created with LeBlender should be prefixed, you are free to do that in the UI.

I'm not really sure what to answer here. Please let me know if I'm mistaking anything here.

[kows]

hi @soreng,
I was not sure it was the intention but it seems like it wasn't by your reply.
I guess Umbraco also checks the package.manifest for the dropdown for creation of data types.

What I am talking about is the following:

[soreng]

Still, I'm not really sure what you are suggesting. The editors in the screenshots are from the starterkit - not LeBlender.

You could also use icons with other colors if you need to distinguish LeBlender-created editors.

[kows]

One final comment, but we might come to an understanding on Slack then first.
The screenshots I took are from the "Developer" -> "Data Types" -> "Create" -> "New data type" screen.
On a fresh Umbraco installation, these do not appear in the dropdown.
They do after installing LeBlender.
I'm guessing this is caused by the property editors listed in package.manifest of LeBlender.
Perhaps this configuration can be moved to another section?
I'm rather new to plugin dev/setup of Umbraco.

EDIT: I am certain they show up there because of the package.manifest, because if I remove that section from the manifest, they disappear from the dropdown.

[bjarnef]

@soreng LeBlender define these property editors in package.manifest, which show up in datatype dropdown in Umbraco.

https://github.com/Lecoati/LeBlender/blob/1e4a1c1851e4d970ea6ad034b7345857b1a01981/Src/Lecoati.LeBlender.Ui/App_Plugins/LeBlender/package.manifest

Sometimes I have seen developers creating datatype instances of the rte instead of the core Umbraco.TinyMCEv3 which can cause some issues, where the rte defined in LeBlender store the value type as TEXT (not sure if it was stored as TEXTpreviously?)

LeBlender/Src/Lecoati.LeBlender.Ui/App_Plugins/LeBlender/package.manifest

Lines 3 to 11 in 1e4a1c1

	{
	"name": "Rich text editor",
	"alias": "rte",
	"isGridEditor": true,
	"editor": {
	"view": "rte",
	"valueType": "TEXT"
	}
	},

It seems is has been fixed in latest version, although I didn't find this version stable, when I tried out this version on existings projects and it only exists a NuGet package.
#61

But I am not sure it these defined property editors in latest version show up i the datatype dropdown?