Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum instructions count is too limiting #106

Open
lordsteva opened this issue Jan 14, 2025 · 0 comments
Open

Maximum instructions count is too limiting #106

lordsteva opened this issue Jan 14, 2025 · 0 comments

Comments

@lordsteva
Copy link

Hey team, is there any specific reason why you stop parsing a transactions if there are more than 4 instructions?

Link: https://github.com/LedgerHQ/app-solana/blob/develop/libsol/message.c#L23

I feel this thing wasn’t changed once you added support for priority fees, and now every transaction effectively has 2 instructions more with prio fee instructions.

We find this too limiting (it was introduced 5 years ago) and suggest bumping this to 6. It would make staking operation signing without blind signing turned on, which would be huge for our users 🙏

Here's an example transactions we'd like supported: https://solscan.io/tx/2GfJeu51Mo5qu8RQ9Jbyd6V3LjBte7zX7mZESSVLA2yScCYXQuTAjw2614RGeo1TBMHaqpGK5ZCja1a6BcdhUANF

List of instructions:
1 - Compute Budget: setComputeUnitPrice
2 - Compute Budget: setComputeUnitLimit
3 - System Program: createAccountWithSeed
4 - Stake Program: initialize
5 - Stake Program: delegate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant