feat: support load code from local file for issue 59 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
reviewed
Feb 22, 2019
src/utils/problemUtils.ts
Outdated
| export function genFileName(node: IProblem, language: string): string { | ||
| const name: string = kebabCase(node.name); | ||
| const ext: string | undefined = langExt.get(language); | ||
| return `${node.id}.${name}.${ext}`; |
There was a problem hiding this comment.
ext here might be undefined. Though according to current logic, it's impossible.
I think you can have another util method here to parse the ext from a language name. Meanwhile, throw an error if the language is not supported.
jdneo
reviewed
Feb 22, 2019
| @@ -0,0 +1,8 @@ | |||
| import kebabCase = require("lodash.kebabcase"); | |||
There was a problem hiding this comment.
It's because of the issue of lodash. T_T
Another way is to change the tsconfig.json. But I think its impact may be even bigger, so I wrote it like this.
jdneo
reviewed
Feb 22, 2019
src/leetCodeExecutor.ts
Outdated
| public async showProblem(node: IProblem, language: string, outDir: string): Promise<string> { | ||
| const fileName: string = genFileName(node, language); | ||
| const filePath: string = path.join(outDir, fileName); | ||
| const hasLocalCode: boolean = await fse.pathExists(filePath); |
There was a problem hiding this comment.
hasLocalCode is redundant. We can move await fse.pathExists(filePath) into the if block.
jdneo
requested changes
Feb 22, 2019
|
I'm sorry for the lint error. T_T |
|
@poppinlp Thank you for the contribution. Nice job! I'll send out another PR to add you the contributors.. |
This was referenced Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RP is for #59. The main logic change is that
showProblemoperation will try to load local code first. Here are the changes:lodash.kebabcasein dependencies to generate a sluglangExtinshared.tsto do the extension mapping for languageproblemUtils.tswhich contains utils for problemshowProbleminleetCodeExecutor.tswill return the code file path right now