Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can't unload tree belonging to a 'group' tab #46

Open
dsl101 opened this issue Nov 6, 2024 · 2 comments
Open

[Bug] Can't unload tree belonging to a 'group' tab #46

dsl101 opened this issue Nov 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@dsl101
Copy link

dsl101 commented Nov 6, 2024

When opening tabs from, for example, a pinned tab, TST collects them together in a group with a URL like moz-extension://[TST-id]/resources/group-tab.html?title=Group... But these tabs behave differently in TST-Tab-Unloader. See the small screen recording to demonstrate. 'Normal' tabs unload the root and whole tree, whereas 'Group' tabs only unload themselves, not their descendent tree (whether by click or the context menu).

Group.Mozilla.Firefox.2024-11-06.16-24-59.mp4
@Lej77
Copy link
Owner

Lej77 commented Nov 6, 2024

I tried it and your right that it isn't working. The reason seems to be that TST fails to handle the get-tree message for group tabs. We could provide a workaround for that but it would likely be better if this bug was fixed in TST itself.

Failed to get Tree Style Tab tree that should be unloaded.
Tab:  
Object { id: 9, windowId: 1, states: (2) […], indent: 0, children: (2) […], ancestorTabIds: [], bundledTabId: -1, active: false, attention: false, audible: false, … }
 
Error:  Error: tab.favIconUrl is null 

Error location: background.js:589:41

@dsl101
Copy link
Author

dsl101 commented Nov 6, 2024

I have a (maybe) related bug as other things stopped working with group tabs recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants