Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergeAttrs not ignored when ignoreAttrs is false #372

Closed
vinhboy opened this issue Apr 5, 2017 · 2 comments
Closed

mergeAttrs not ignored when ignoreAttrs is false #372

vinhboy opened this issue Apr 5, 2017 · 2 comments

Comments

@vinhboy
Copy link

vinhboy commented Apr 5, 2017

In the documentation, for mergeAttrs, it says that "This option is ignored if ignoreAttrs is false."

However, when I set ignoreAttrs: false

This

    <link href="google.com"/>
    <link href="yahoo.com"/>

Becomes

    // mergeAttrs: false
    {link: [{ '$': { href: 'google.com' } },{ '$': { href: 'yahoo.com' } }]}
    // mergeAttrs: true
    {link: [ { href: 'google.com' }, { href: 'yahoo.com' }]}

Personally, this works out well for me because that's what I want. But the documentation is misleading.

It would be even better if it did this

    // mergeAttrs: true
    {link: { href: ['google.com', 'yahoo.com'] }}

May be related to: #367

@jcsahnwaldt
Copy link
Contributor

The documentation is wrong. It should read:

This option is ignored if ignoreAttrs is true.

@Leonidas-from-XIV
Copy link
Owner

Fixed, thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants