Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly depend on abstract-level for TypeScript #241

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Explicitly depend on abstract-level for TypeScript #241

merged 1 commit into from
Jan 27, 2024

Conversation

lianghx-319
Copy link
Contributor

@lianghx-319 lianghx-319 commented Jan 26, 2024 •
edited
Loading

When using pnpm as package manager, and disabled dependencies hoist, level will miss the type declare of abstract-level

This will cause db.close missing, because typescript cannot resolve the abstract-level.

@vweevers
Copy link
Member

Test failure is unrelated; fixed in #242.

@vweevers vweevers changed the title Fix missing abstract-level type declare when pnpm disable hoist Explicitly depend on abstract-level for TypeScript Jan 27, 2024
@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Jan 27, 2024
@vweevers vweevers merged commit c501868 into Level:master Jan 27, 2024
4 of 5 checks passed
@vweevers vweevers mentioned this pull request Jan 27, 2024
Closed
@vweevers
Copy link
Member

8.0.1

This was referenced Jul 17, 2024
Open
Open
Open
Open
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lianghx-319 @vweevers