Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM support #243

Open
pleerock opened this issue Feb 28, 2024 · 4 comments
Open

ESM support #243

pleerock opened this issue Feb 28, 2024 · 4 comments

Comments

@pleerock
Copy link

ESM support is required these days in most projects. Would be great to have ESM support. Right now using stuff like __dirname blocks usages of these packages in ESM modules.

@vweevers
Copy link
Member

Under which runtime? It will work fine in Node.js and probably that new Bare thing too, but I don't know about Bun, Deno, LLRT. And when using a bundler, that bundler can be configured to inject __dirname.

Moving to ESM is a disruptive change, because then the modules can't be used from CJS anymore. I'm not saying it will never happen, but we should not take it lightly.

@pleerock
Copy link
Author

In my case I have Node.js runtime (via Electron), the bundler I'm using is Vite, however it doesn't replace __dirname from Level package. Not sure why, maybe because Level is used in another library which is ESM module and dependency of the main (Electron, it's Node.js process) package (all inside monorepo).

@vweevers
Copy link
Member

@pleerock
Copy link
Author

@vweevers thanks for the hint, I'll try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants