Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node 12 to AppVeyor (or check what their schedule is) #630

Closed
vweevers opened this issue May 5, 2019 · 4 comments
Closed

Add node 12 to AppVeyor (or check what their schedule is) #630

vweevers opened this issue May 5, 2019 · 4 comments
Labels
maintenance General maintenance question Support or open question(s)

Comments

@vweevers
Copy link
Member

vweevers commented May 5, 2019

Forked from #628 (comment)

@ralphtheninja
@vweevers vweevers added question Support or open question(s) maintenance General maintenance labels May 5, 2019
@vweevers
Copy link
Member Author

appveyor/ci#2921 (comment)

@vweevers
Copy link
Member Author

I'm fine with waiting for AppVeyor to catch up. If there's an issue on node 12, that'd be a bug in N-API and not ours to fix.

However, just now I tested node 12 on Windows, and it seems that node-gyp-build doesn't find a prebuild. That happens on every node version in fact, so it's (I hope) some problem with my setup because it worked before. Trying to figure out what's going on.

Error: No native build was found for platform=win32 arch=x64 runtime=node abi=72 uv=1 libc=glibc

@vweevers
Copy link
Member Author

Oh, duh, I have prebuilds that were made with the previous version of prebuildify and its naming scheme. Nevermind 😄

@vweevers
Copy link
Member Author

Yeah, with that out of the way, node 12 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance General maintenance question Support or open question(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vweevers