Upgrade napi-macros #657
Merged
Upgrade napi-macros #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
commented
Aug 11, 2019
| @@ -11,7 +11,7 @@ | |||
| "test-electron": "electron test/electron.js", | |||
| "test-prebuild": "cross-env PREBUILDS_ONLY=1 npm t", | |||
| "coverage": "nyc report --reporter=text-lcov | coveralls", | |||
| "rebuild": "node-gyp rebuild", | |||
| "rebuild": "npm run install --build-from-source", | |||
There was a problem hiding this comment.
Small unrelated change; previously npm run rebuild would not use the locally-installed node-gyp.
This was referenced Aug 11, 2019
ralphtheninja
approved these changes
Aug 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
NAPI_STATUS_THROWSmacro was changed toreturn NULL(mafintosh/napi-macros#13), I switched toNAPI_STATUS_THROWS_VOIDin places where we can't return null (i.e. constructors).Supersedes #644.