Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Refactor promisify() code by using catering module #700

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Conversation

ralphtheninja
Copy link
Member

Closes #699

@ralphtheninja ralphtheninja added the semver-patch Bug fixes that are backward compatible label Sep 26, 2020
@vweevers
Copy link
Member

Could be considered a breaking change because we did if (!callback) here, while catering does if (callback === undefined). The latter matches documented behavior though so I think it's OK. The docs never suggested we support e.g. await db.get('foo', null) the same as await db.get('foo').

@ralphtheninja ralphtheninja merged commit 33b1318 into master Sep 27, 2020
@ralphtheninja ralphtheninja deleted the catering branch September 27, 2020 08:14
@ralphtheninja
Copy link
Member Author

Could be considered a breaking change because we did if (!callback) here, while catering does if (callback === undefined). The latter matches documented behavior though so I think it's OK. The docs never suggested we support e.g. await db.get('foo', null) the same as await db.get('foo').

Good catch. I didn't think that far. My OCD just told me to replace the code with your tested module :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to use fromCallback from catering module
2 participants