This repository was archived by the owner on Dec 20, 2024. It is now read-only.
fix: pass options to level #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes options to level implementation as well as levelup wrapper.
This was referenced Nov 25, 2019
vweevers
approved these changes
Nov 29, 2019
|
5.1.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use the
prefixoption oflevel-jsto overridethis.prefix, but theoptionsarg is not being passed tolevel-js.This PR passes options to the specified
levelimplementation and adds a test for the same. It also renames a couple of the tests to be more specific as they test the options were passed to thelevelupwrapper, rather than the underlyinglevelimplementation, which is what the added test tests.