Build a universal binary to support M1 (Apple silicon) #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buu700
added a commit
to buu700/rocksdb-tmp
that referenced
this pull request
Sep 21, 2021
|
Looks good to me, thanks @Nazgolze! |
|
Can we make this work for a universal binary as well? See Level/leveldown#781 for comparison - I want to do the same for rocksdb |
vweevers
requested changes
Sep 24, 2021
remove related architecture check (the #if defined(... covers that)
vweevers
reviewed
Sep 24, 2021
vweevers
approved these changes
Sep 24, 2021
vweevers
changed the title
|
Note to self: on release, compare prebuild binary size to the previous release |
|
5.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177
Since this change is around cpu architecture and not OS, I did some testing on Ubuntu ARM64. Interestingly, 5.1.0 here did not have the same issue as on the Mac M1. Nevertheless, I've tested this PR on the M1 Mac and Ubuntu ARM64, have not encountered any errors and, so far, it's working well in our app (though the more eyeballs, the better - if @buu700 is able to give this a try as well 🙏 )