Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer ? #17

Open
dbuenzli opened this issue Jan 12, 2019 · 8 comments
Open

Viewer ? #17

dbuenzli opened this issue Jan 12, 2019 · 8 comments

Comments

@dbuenzli
Copy link

Hello,

The online viewer is a 404 and the package landmarks-viewer mentioned in the README doesn't exist.

@nilsbecker
Copy link

is there a way to use landmarks in json mode currently at all?

@Armael
Copy link

Armael commented Jan 19, 2020

I'm trying to use landmarks and just hit this issue. Are there any updates?

@Armael
Copy link

Armael commented Jan 19, 2020

FYI: I've just hacked a mode to write the "textual format" in a way that is readable by emacs' org-mode (in particular, this supports folding/unfolding items of the tree), which makes for a very usable viewer.

The code is here, I'll make a PR at some point: https://github.com/Armael/landmarks/tree/format-org

lm-org

@mlasson
Copy link
Member

mlasson commented Jan 20, 2020

Hello everyone,

I revived the landmarks-viewer !

You should be able to test it online.
Just run your executable with OCAML_LANDMARKS=format=json,output=profile.json and load the file in the online viewer.

If you want to have it locally, you can clone the repository.
The instructions in the README.md should be enough to build the two files ("landmark_viewer.html" and "landmark_viewer.js").

Note that you'll need the master branch version of gen_js_api (it has not yet been released to opam).
And I'll try to release the viewer on opam as soon as gen_js_api is released !

@mlasson
Copy link
Member

mlasson commented Jan 20, 2020

I'll close the issue when it will be available on opam.

@gasche
Copy link

gasche commented Mar 25, 2021

What is the current status of:

  • the landmarks viewer as an opam package?
  • @Armael's org-mode output?

@Armael
Copy link

Armael commented Mar 25, 2021

I haven't touched the org-mode output since last time, but IIRC it was basically working and the patch was clean.
It's still sitting in the branch linked above.

Since the online viewer wasn't working for me (haven't investigated why), I've used my org-mode output a couple times since then.

So I think it's mostly a matter of rebasing it and making the PR. I don't have time right now, but I'm happy to give you access to my fork if you have some cycles available.

@gasche
Copy link

gasche commented Mar 25, 2021

Thanks! I don't need write commit to your fork (I can fetch your fork and resubmit a PR if need be, which sounds cleaner); it just landed in the middle section of my TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants