Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include header for calling rfbssl_init() #501

Closed
derekschrock opened this issue Feb 15, 2022 · 2 comments
Closed

include header for calling rfbssl_init() #501

derekschrock opened this issue Feb 15, 2022 · 2 comments

Comments

@derekschrock
Copy link
Contributor

I don't know if this info is old but based off the recommendation here #91 (comment) it seems that you're asking servers to set the cert and key then execute rfbssl_init() when they want to init an SSL server.

However, rfbssl_init() isn't in a .h file provided by the project. Should the prototype for rfbssl_init() be included in rfb.h or another file rfb_ssl.h be installed?

It seems that if websockets support is fully enabled then just setting the cert and key would be enough setup for SSL then rfbRunEventLoop will init ssl in time.

I guess the alt. is to just extern rfbssl_init() however it seems that function should be in a .h if you expecting servers to execute the function.

@bk138
Copy link
Member

bk138 commented Feb 15, 2022

IIRC the function is for internal use only, we got several implementations (OpenSSL, GnuTLS) which are exposed by rfbssl.h, the only user right now is websockets.c, though this will hopefully change with #396 some time. The user/developer documentation is here so it boils down to setting key and cert and the library will take over the rest internally.

Does this answer your question?

@derekschrock
Copy link
Contributor Author

Ok I couldn't tell if it was internal. Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants