You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The change to the wait_on_start feature of the MPIExecutor in 1ba9f57 to change it from bool to either bool or int looks like it results in MPIExecutor.fail_time always being ignored.
In the case wait_on_start=True it looks like MPIExecutor.fail_time should be used to set the wait time. However, the check
always passes with the first condition because bool is a subclass of int. This can cause failed simulations to not be caught if fail_time > 1 was needed.
The text was updated successfully, but these errors were encountered:
The change to the
wait_on_start
feature of the MPIExecutor in 1ba9f57 to change it from bool to either bool or int looks like it results in MPIExecutor.fail_time always being ignored.In the case
wait_on_start=True
it looks like MPIExecutor.fail_time should be used to set the wait time. However, the checklibensemble/libensemble/executors/mpi_executor.py
Line 169 in 2892c86
always passes with the first condition because bool is a subclass of int. This can cause failed simulations to not be caught if fail_time > 1 was needed.
The text was updated successfully, but these errors were encountered: