Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPIExecutor wait_time always set by wait_on_start #1468

Open
cchall opened this issue Nov 15, 2024 · 0 comments
Open

MPIExecutor wait_time always set by wait_on_start #1468

cchall opened this issue Nov 15, 2024 · 0 comments

Comments

@cchall
Copy link

cchall commented Nov 15, 2024

The change to the wait_on_start feature of the MPIExecutor in 1ba9f57 to change it from bool to either bool or int looks like it results in MPIExecutor.fail_time always being ignored.

In the case wait_on_start=True it looks like MPIExecutor.fail_time should be used to set the wait time. However, the check

wait_time = wait_on_start if isinstance(wait_on_start, int) else self.fail_time

always passes with the first condition because bool is a subclass of int. This can cause failed simulations to not be caught if fail_time > 1 was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant