nginx.conf does not update when containers are renamed

[Atinoda]

Thanks for putting together this container stack - it's certainly a complicated piece of software!

I needed to rename the containers for my application, and I'll echo #80 in saying that rename did not work for the deployment. Manually changing container names and corresponding variables in .env and docker-compose.yml got 99% of the work done however, it is also necessary to edit proxy/nginx.conf and update the frontend and backend hostnames there. I mounted the updated file directly into the container as a workaround (i.e., - ./proxy/nginx.conf:/etc/nginx/nginx.conf)

As a suggestion, librephotos-* could be used as the container naming pattern, and this is less likely to require user renaming due to conflicts with other stacks (and avoids the need to do a big rewrite for dynamic renaming capability).

[jo-chemla]

Thanks for the workaround, mounting - ./proxy/nginx.conf:/etc/nginx/nginx.conf in the librephotos_proxy container and adapting it from nginx.conf file!

Indeed would be great if container names were editablen directly within the docker-compose, for example through environment variables. EDIT: Actually, this interesting issue thread #87 explains that BACKEND_NAME and FRONTEND_NAME were env variables to the proxy container but are now removed.

2nd note: I was able to apply your workaround with

• librephotos-db: only via compose file edits, namely db container_id, db container_name, proxy depends_on and backend env DB_HOST
• librephotos-frontend: in compose (~same as above) + nginx.conf proxy_pass rows,
• and librephotos-backend: again, backend container_id, backend container_name, proxy depends_on and backend env BACKEND_HOST + nginx.conf proxy_pass rows. Do not change proxy_set_header Host backend;!