Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"contact on slack" stopped working #530

Open
glbert-does opened this issue Mar 4, 2024 · 0 comments · May be fixed by #532
Open

"contact on slack" stopped working #530

glbert-does opened this issue Mar 4, 2024 · 0 comments · May be fixed by #532
Labels
bug good first issue P2 - medium Improves general league experience (avoids some mod summons, fixes minor annoyance)

Comments

@glbert-does
Copy link
Member

glbert-does commented Mar 4, 2024 •
edited
Loading

"contact on slack", on player pages, e.g. https://www.lichess4545.com/team4545/player/glbert/ stopped working. it will just open #general, not a dm.

currently we use the format https://lichess4545.slack.com/messages/[user_id]/ here:

heltour/heltour/tournament/templates/tournament/player_profile.html

Line 47 in 1d5fd89

<a href="https://lichess4545.slack.com/messages/{{ player.slack_user_id }}/">Message {{ player.lichess_username }}

as far as i can tell, instead using the format https://app.slack.com/client/[team_id]/[user_id] would work. edit: it doesn't work. instead, https://slack.com/app_redirect?team=[team_id]&channel=[user_id] sort of works, but maybe there is a better solution.

marked this as "good first issue" for now, because i assume that it is. but i might be wrong.
@glbert-does glbert-does added bug P2 - medium Improves general league experience (avoids some mod summons, fixes minor annoyance) good first issue labels Mar 4, 2024
@glbert-does glbert-does linked a pull request Mar 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue P2 - medium Improves general league experience (avoids some mod summons, fixes minor annoyance)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix contact on slack glbert-does/heltour
1 participant
@glbert-does