Updated SparseML callback for latest PyTorch Lightning #822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes an issue, where
steps_per_epoch
had to be positive. With recent pl lightning, it is -1 so it raises an error.max_steps
(now defaults to-1
), leading the callback to passtrainer.max_steps
tosteps_per_epoch
, raising an error,num_gpus
,num_processes
andtpu_cores
. Those attributes will be deleted, and we should usenum_devices
instead. To avoid breaking changes, the old behavior stays the same iftrainer
has nonum_devices
attribute.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃