Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add required for positional arguments #12504

Merged
merged 6 commits into from
Apr 22, 2022
Merged

Conversation

fschlatt
Copy link
Contributor

add required for positional arguments

What does this PR do?

Makes positional arguments of a class required in the argument parser returned by add_argparse_args.

Fixes #12503

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

add required for positional arguments

add required for positional arguments

move argument to correct spot

add required to argument parser for positional cls arguments
@ananthsub ananthsub added the argparse (removed) Related to argument parsing (argparse, Hydra, ...) label Mar 29, 2022
@Borda Borda enabled auto-merge (squash) March 30, 2022 06:13
@Borda Borda added the refactor label Mar 30, 2022
@awaelchli awaelchli added this to the 1.7 milestone Apr 3, 2022
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@mergify mergify bot added the ready PRs ready to be merged label Apr 3, 2022
auto-merge was automatically disabled April 22, 2022 12:34

Head branch was pushed to by a user without write access

@carmocca carmocca merged commit f4f70a8 into Lightning-AI:master Apr 22, 2022
@carmocca carmocca added the community This PR is from the community label Apr 22, 2022
@carmocca carmocca self-assigned this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) community This PR is from the community ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make positional arguments required in the argument parser
5 participants