-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add required for positional arguments #12504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add required for positional arguments add required for positional arguments move argument to correct spot add required to argument parser for positional cls arguments
fschlatt
requested review from
Borda,
tchaton,
SeanNaren,
carmocca,
williamFalcon,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
March 29, 2022 09:30
for more information, see https://pre-commit.ci
ananthsub
added
the
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
label
Mar 29, 2022
Borda
approved these changes
Mar 30, 2022
awaelchli
approved these changes
Apr 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
carmocca
approved these changes
Apr 4, 2022
carmocca
reviewed
Apr 4, 2022
auto-merge was automatically disabled
April 22, 2022 12:34
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
argparse (removed)
Related to argument parsing (argparse, Hydra, ...)
community
This PR is from the community
ready
PRs ready to be merged
refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add required for positional arguments
What does this PR do?
Makes positional arguments of a class required in the argument parser returned by
add_argparse_args
.Fixes #12503
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃