Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version header to CLI config files #12532

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 30, 2022

What does this PR do?

Uses: omni-us/jsonargparse#79

Example config:

# pytorch_lightning==1.7.0dev
seed_everything: null
trainer:
  logger: true
  checkpoint_callback: null
  enable_checkpointing: true
  callbacks: null
  default_root_dir: null
  gradient_clip_val: null
  gradient_clip_algorithm: null

Does your PR introduce any breaking changes? If yes, please list them.

The jsonargparse version was updated.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa

@carmocca carmocca added feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI labels Mar 30, 2022
@carmocca carmocca added this to the 1.7 milestone Mar 30, 2022
@carmocca carmocca requested review from Borda and tchaton as code owners March 30, 2022 15:00
@carmocca carmocca self-assigned this Mar 30, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 30, 2022
@carmocca carmocca enabled auto-merge (squash) April 6, 2022 15:15
@carmocca carmocca disabled auto-merge April 7, 2022 12:01
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rohitgr7 rohitgr7 merged commit 124b529 into master Apr 7, 2022
@rohitgr7 rohitgr7 deleted the feat/cli-version-header branch April 7, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants