-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated stochastic_weight_avg
argument from Trainer
#12535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
rohitgr7
requested review from
williamFalcon,
tchaton,
awaelchli,
SeanNaren,
carmocca,
Borda,
justusschock and
kaushikb11
as code owners
March 30, 2022 17:53
ananthsub
added
breaking change
Includes a breaking change
trainer: argument
and removed
deprecation
Includes a deprecation
labels
Mar 30, 2022
rohitgr7
changed the title
Remove deprecated stochastic_weight_averaging flag from Trainer
Remove deprecated Mar 30, 2022
stochastic_weight_averaging
flag from Trainer
@ananthsub how is this a breaking change? |
@rohitgr7 It would be a breaking change for the users as we are removing the Trainer flag. |
ananthsub
approved these changes
Mar 31, 2022
Co-authored-by: ananthsub <2382532+ananthsub@users.noreply.github.com>
kaushikb11
approved these changes
Mar 31, 2022
ananthsub
changed the title
Remove deprecated
Remove deprecated Mar 31, 2022
stochastic_weight_averaging
flag from Trainer
stochastic_weight_avg
flag from Trainer
ananthsub
reviewed
Mar 31, 2022
Co-authored-by: ananthsub <2382532+ananthsub@users.noreply.github.com>
rohitgr7
changed the title
Remove deprecated
Remove deprecated Mar 31, 2022
stochastic_weight_avg
flag from Trainer
stochastic_weight_avg
argument from Trainer
carmocca
approved these changes
Mar 31, 2022
Borda
approved these changes
Mar 31, 2022
awaelchli
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
callback: swa
ready
PRs ready to be merged
refactor
trainer: argument
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #12521
required for: #11822
resolves #8989
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @carmocca @justusschock @kaushikb11 @awaelchli @rohitgr7 @tchaton