-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated get_memory_profile #12659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve issue Lightning-AI#12521
puhuk
requested review from
tchaton,
carmocca,
Borda,
SeanNaren,
justusschock,
kaushikb11,
williamFalcon,
awaelchli and
rohitgr7
as code owners
April 7, 2022 15:29
for more information, see https://pre-commit.ci
…-lightning into get_memory_profile
for more information, see https://pre-commit.ci
…-lightning into get_memory_profile
awaelchli
approved these changes
Apr 9, 2022
awaelchli
added
breaking change
Includes a breaking change
logging
Related to the `LoggerConnector` and `log()`
labels
Apr 9, 2022
awaelchli
reviewed
Apr 9, 2022
Borda
approved these changes
Apr 9, 2022
44 tasks
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Apr 9, 2022
akihironitta
reviewed
Apr 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@puhuk Would you mind removing the deprecated function from the following test case?
https://github.com/PyTorchLightning/pytorch-lightning/blob/c233731b7c55d2533ab76eecf609e8df0e0ebfc3/tests/deprecated_api/test_remove_1-7.py#L54
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Apr 11, 2022
for more information, see https://pre-commit.ci
…-lightning into get_memory_profile
carmocca
approved these changes
Apr 11, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
logging
Related to the `LoggerConnector` and `log()`
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve issue #12521
What does this PR do?
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃