Update core/lightning.py to core/module.py

[tanmoyio]

What does this PR do?

Fixes #10499

Does your PR introduce any breaking changes? If yes, please list them.

While running make test I got some CUDA errors, I think that's issue from my side and some of the tests need nvidia/apex, deepspeed etc which I don't have in my system.

result:

220 failed, 2509 passed, 335 skipped, 12 xfailed, 4996 warnings, 3 rerun

some of the errors I got

FAILED tests/trainer/optimization/test_manual_optimization.py::test_multiple_optimizers_step - RuntimeError: CUDA error: invalid device function
FAILED tests/trainer/optimization/test_manual_optimization.py::test_step_with_optimizer_closure_with_different_frequencies_ddp_spawn - torch.multiprocessing.spawn.ProcessRaise...
FAILED tests/trainer/optimization/test_manual_optimization.py::test_multiple_optimizers_logging[16] - RuntimeError: CUDA error: invalid device function
FAILED tests/trainer/optimization/test_manual_optimization.py::test_multiple_optimizers_logging[32] - RuntimeError: CUDA error: invalid device function
FAILED tests/trainer/properties/test_get_model.py::test_get_model_gpu - RuntimeError: CUDA error: invalid device function
FAILED tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_trainer_arg[power] - RuntimeError: CUDA error: invalid device function
FAILED tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_trainer_arg[binsearch] - RuntimeError: CUDA error: invalid device function
FAILED tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_trainer_arg[True] - RuntimeError: CUDA error: invalid device function
FAILED tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_set_model_attribute[True] - RuntimeError: CUDA error: invalid device function
FAILED tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_set_model_attribute[False] - RuntimeError: CUDA error: invalid device function
FAILED tests/tuner/test_scale_batch_size.py::test_auto_scale_batch_size_with_amp - RuntimeError: CUDA error: invalid device function
FAILED tests/utilities/test_cli.py::test_cli_distributed_save_config_callback[ddp_spawn-False] - AssertionError: Regex pattern 'Error on fit start' does not match '\n\n-- Proc...
FAILED tests/utilities/test_cli.py::test_cli_distributed_save_config_callback[ddp_spawn-True] - AssertionError: Regex pattern 'Error on fit start' does not match '\n\n-- Proce...
FAILED tests/utilities/test_cli.py::test_cli_distributed_save_config_callback[ddp-False] - RuntimeError: CUDA error: invalid device function
FAILED tests/utilities/test_cli.py::test_cli_distributed_save_config_callback[ddp-True] - RuntimeError: CUDA error: invalid device function
FAILED tests/utilities/test_distributed.py::test_collect_states - torch.multiprocessing.spawn.ProcessRaisedException:
FAILED tests/utilities/test_dtype_device_mixin.py::test_submodules_multi_gpu_dp - RuntimeError: CUDA error: invalid device function
FAILED tests/utilities/test_dtype_device_mixin.py::test_submodules_multi_gpu_ddp_spawn - torch.multiprocessing.spawn.ProcessRaisedException:
FAILED tests/utilities/test_fetching.py::test_trainer_num_prefetch_batches - RuntimeError: CUDA error: invalid device function
FAILED tests/utilities/test_model_summary.py::test_linear_model_summary_shapes[device1--1] - RuntimeError: CUDA error: invalid device function
FAILED tests/utilities/test_model_summary.py::test_linear_model_summary_shapes[device1-1] - RuntimeError: CUDA error: invalid device function
FAILED tests/utilities/test_model_summary.py::test_model_size_precision - RuntimeError: CUDA error: invalid device function

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

[justusschock]

Hey @tanmoyio thank you for working on this. Already looks pretty good. What's mainly missing:

• A changelog entry
• A file under the old name forwarding the import and raising a deprecation warning
• A test for the deprecation warning :)

[rohitgr7]

A file under the old name forwarding the import and raising a deprecation warning
A test for the deprecation warning :)

should it be done in a follow-up? else git diff might be huge here.

[tanmoyio]

@justusschock @rohitgr7 is it looking good now?

[akihironitta]

@tanmoyio Sorry for the delay! Could you merge or rebase master?

[akihironitta]

@carmocca Do we need to split this PR into two as suggested by @rohitgr7? #12740 (comment)

[carmocca]

I would say yes. For such a large change, we need to split moving code from modifying code

[tanmoyio]

@akihironitta I have updated, let me know if I need to change anything else

[awaelchli]

Gatekeeper merge