-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for custom DataLoader
s when instantiated in *_dataloader
hook
#12981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaj
added
bug
Something isn't working
data handling
Generic data-related topic
trainer: predict
labels
May 5, 2022
otaj
requested review from
carmocca,
williamFalcon,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
May 5, 2022 12:31
carmocca
reviewed
May 5, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
I think I replied to all of your comments @carmocca. I applied most of your suggestions, would you mind taking another look? Thanks! |
carmocca
reviewed
May 6, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
awaelchli
approved these changes
Jun 21, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
ready
PRs ready to be merged
labels
Jun 21, 2022
justusschock
approved these changes
Jun 21, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 21, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 21, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12917
Improve support for custom
DataLoader
s when instantiated in*_dataloader
hook. If the DataLoader is a valid DataLoader, there is now a lower chance that things we will break the DataLoader when injecting custom arguments.Also, if things break due to our injecting, we throw better error messages.
Does your PR introduce any breaking changes? If yes, please list them.
DataLoader
instantiated inside a hook will now not instantiate attributes for you automatically. Before this PR, this code would work:After this PR, this code would no longer work. This was an internal behavior.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @ninginthecloud @rohitgr7 @otaj