-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated checkpoint_callback
flag in Trainer
#13027
Merged
akihironitta
merged 7 commits into
Lightning-AI:master
from
shenoynikhil:trainer-remove-ckpt-callback
May 11, 2022
Merged
Remove deprecated checkpoint_callback
flag in Trainer
#13027
akihironitta
merged 7 commits into
Lightning-AI:master
from
shenoynikhil:trainer-remove-ckpt-callback
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenoynikhil
changed the title
Removed lines pertinent to checkpoint_callback
[WIP] Removing Deprecated checkpoint_callback flag in Trainer
May 10, 2022
Dependence in Other Important RepostoriesBased on @kaushikb11, I did a search on grep.app and found multiple important examples from |
@akihironitta This is my first contribution to PL, let me know if I have missed something obvious :). |
shenoynikhil
requested review from
williamFalcon,
tchaton,
awaelchli,
SeanNaren,
carmocca,
Borda,
edenlightning,
justusschock,
kaushikb11 and
rohitgr7
as code owners
May 10, 2022 18:02
akihironitta
approved these changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! LGTM!
akihironitta
changed the title
[WIP] Removing Deprecated checkpoint_callback flag in Trainer
Removing Deprecated checkpoint_callback flag in Trainer
May 10, 2022
ananthsub
approved these changes
May 10, 2022
akihironitta
changed the title
Removing Deprecated checkpoint_callback flag in Trainer
Remove deprecated May 11, 2022
checkpoint_callback
flag in Trainer
rohitgr7
approved these changes
May 11, 2022
carmocca
approved these changes
May 11, 2022
Borda
approved these changes
May 11, 2022
awaelchli
approved these changes
May 11, 2022
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
community
This PR is from the community
ready
PRs ready to be merged
trainer: argument
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12521
What does this PR do?
This PR removes the
checkpoint_callback
flag from the Trainer Class. Following edits happen,Does your PR introduce any breaking changes? If yes, please list them.
resolves #9754
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃