Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Support custom trainers without callbacks #13138

Merged
merged 4 commits into from
Jun 28, 2022
Merged

[CLI] Support custom trainers without callbacks #13138

merged 4 commits into from
Jun 28, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 24, 2022 •
edited by github-actions bot
Loading

What does this PR do?

The CLI currently imposes the requirement that the callbacks and fast_dev_run arguments exist. This PR relaxes it.

Reported in Slack

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @mauvilsa

@carmocca carmocca added feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI labels May 24, 2022
@carmocca carmocca added this to the 1.7 milestone May 24, 2022
@carmocca carmocca self-assigned this May 24, 2022
@carmocca carmocca force-pushed the bugfix/cli-support-no-callbacks branch from dbd2269 to d73fc7b Compare May 24, 2022 11:05
@carmocca carmocca marked this pull request as ready for review May 24, 2022 11:06
akihironitta
akihironitta approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carmocca carmocca force-pushed the bugfix/cli-support-no-callbacks branch from 9545a0d to 005c2b4 Compare June 21, 2022 15:23
@mergify mergify bot removed the has conflicts label Jun 21, 2022
@mergify mergify bot removed the has conflicts label Jun 22, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Jun 23, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 27, 2022
@carmocca carmocca enabled auto-merge (squash) June 28, 2022 12:00
Borda
Borda approved these changes Jun 28, 2022
View reviewed changes
src/pytorch_lightning/utilities/cli.py Show resolved Hide resolved
src/pytorch_lightning/utilities/cli.py Show resolved Hide resolved
src/pytorch_lightning/utilities/cli.py Show resolved Hide resolved
@carmocca carmocca merged commit a475010 into master Jun 28, 2022
@carmocca carmocca mentioned this pull request Jun 28, 2022
Merged
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@carmocca @jerome-habana
[CLI] Support custom trainers without callbacks (Lightning-AI#13138)
fa7e854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@akihironitta akihironitta akihironitta approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees

@carmocca carmocca

Labels
feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @Borda @akihironitta