Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors for logging corner cases #13164

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 26, 2022

What does this PR do?

Fixes #12863

Does your PR introduce any breaking changes? If yes, please list them.

Logging a non-scalar tensor now raises an error instead of computing the mean internally.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy

@carmocca carmocca added feature Is an improvement or enhancement logging Related to the `LoggerConnector` and `log()` breaking change Includes a breaking change labels May 26, 2022
@carmocca carmocca added this to the 1.7 milestone May 26, 2022
@carmocca carmocca self-assigned this May 26, 2022
@carmocca carmocca marked this pull request as ready for review May 26, 2022 19:53
pytorch_lightning/core/module.py Outdated Show resolved Hide resolved
@carmocca carmocca force-pushed the feat/logging-corner-cases branch from bc196da to 38ffc89 Compare June 21, 2022 15:38
@mergify mergify bot removed the has conflicts label Jun 27, 2022
@carmocca carmocca enabled auto-merge (squash) June 28, 2022 12:00
@mergify mergify bot added the ready PRs ready to be merged label Jun 28, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit b1e38bf into master Jun 28, 2022
@carmocca carmocca deleted the feat/logging-corner-cases branch June 28, 2022 15:59
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes a breaking change feature Is an improvement or enhancement logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour when logging an non-scalar tensor.
4 participants