-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better errors for logging corner cases #13164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
feature
Is an improvement or enhancement
logging
Related to the `LoggerConnector` and `log()`
breaking change
Includes a breaking change
labels
May 26, 2022
carmocca
requested review from
tchaton,
SeanNaren,
Borda,
justusschock,
kaushikb11,
williamFalcon,
awaelchli and
rohitgr7
as code owners
May 26, 2022 19:53
awaelchli
approved these changes
May 30, 2022
carmocca
force-pushed
the
feat/logging-corner-cases
branch
from
June 21, 2022 15:38
bc196da
to
38ffc89
Compare
Borda
approved these changes
Jun 28, 2022
tchaton
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
jerome-habana
pushed a commit
to jerome-habana/lightning
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
feature
Is an improvement or enhancement
logging
Related to the `LoggerConnector` and `log()`
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12863
Does your PR introduce any breaking changes? If yes, please list them.
Logging a non-scalar tensor now raises an error instead of computing the
mean
internally.Before submitting
PR review
cc @Borda @carmocca @edward-io @ananthsub @rohitgr7 @kamil-kaczmarek @Raalsky @Blaizzy