-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EarlyStopping logging on rank 0 only #13233
Merged
awaelchli
merged 9 commits into
Lightning-AI:master
from
ekagra-ranjan:feature/earlystopping-rank-0
Jun 21, 2022
Merged
EarlyStopping logging on rank 0 only #13233
awaelchli
merged 9 commits into
Lightning-AI:master
from
ekagra-ranjan:feature/earlystopping-rank-0
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekagra-ranjan
requested review from
williamFalcon,
tchaton,
carmocca,
Borda,
kaushikb11,
SeanNaren,
awaelchli,
justusschock and
rohitgr7
as code owners
June 5, 2022 19:35
carmocca
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
akihironitta
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
for more information, see https://pre-commit.ci
ekagra-ranjan
force-pushed
the
feature/earlystopping-rank-0
branch
from
June 17, 2022 07:12
a5be246
to
69e1007
Compare
mergify
bot
added
ready
PRs ready to be merged
and removed
ready
PRs ready to be merged
labels
Jun 17, 2022
awaelchli
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
callback: early stopping
community
This PR is from the community
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a flag to turn off logging EarlyStopping in non-zero rank processes.
Fixes #13162
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc: @carmocca @Borda