Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EarlyStopping logging on rank 0 only #13233

Merged

Conversation

ekagra-ranjan
Copy link
Contributor

@ekagra-ranjan ekagra-ranjan commented Jun 5, 2022

What does this PR do?

Adds a flag to turn off logging EarlyStopping in non-zero rank processes.

Fixes #13162

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc: @carmocca @Borda

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

tests/callbacks/test_early_stopping.py Outdated Show resolved Hide resolved
@carmocca carmocca added feature Is an improvement or enhancement callback: early stopping labels Jun 6, 2022
@carmocca carmocca added this to the 1.7 milestone Jun 6, 2022
@carmocca carmocca added the community This PR is from the community label Jun 6, 2022
@carmocca carmocca self-assigned this Jun 6, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@mergify mergify bot added the ready PRs ready to be merged label Jun 7, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 15, 2022
@ekagra-ranjan ekagra-ranjan force-pushed the feature/earlystopping-rank-0 branch from a5be246 to 69e1007 Compare June 17, 2022 07:12
@mergify mergify bot removed the has conflicts label Jun 17, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Jun 17, 2022
@awaelchli awaelchli merged commit 81b7000 into Lightning-AI:master Jun 21, 2022
@ekagra-ranjan ekagra-ranjan deleted the feature/earlystopping-rank-0 branch February 24, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback: early stopping community This PR is from the community feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] EarlyStopping logging on rank 0 only
4 participants