-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LightningCLI signature parameter resolving for some lightning classes #13283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
feature
Is an improvement or enhancement
lightningcli
pl.cli.LightningCLI
labels
Jun 14, 2022
carmocca
reviewed
Jun 14, 2022
mauvilsa
changed the title
Fix for LightningCLI signature parameter resolving for some lightning classes
Fix LightningCLI signature parameter resolving for some lightning classes
Jun 14, 2022
…arse parameter resolvers.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mauvilsa
requested review from
williamFalcon,
edenlightning,
Borda,
tchaton,
SeanNaren,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
June 16, 2022 20:52
The jsonargparse version is 4.10.0.dev2 because from feedback here it might make sense to change things before a final release. Though the idea is that this pull request is merged only when 4.10.0 is out. |
awaelchli
approved these changes
Jun 18, 2022
carmocca
approved these changes
Jun 21, 2022
mergify
bot
added
ready
PRs ready to be merged
has conflicts
and removed
ready
PRs ready to be merged
labels
Jun 21, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 21, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jun 21, 2022
Borda
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
This PR is from the community
feature
Is an improvement or enhancement
lightningcli
pl.cli.LightningCLI
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses a new version of jsonargparse that extended the support for
**kwargs
to properly find signature parameters where possible by inspecting the source code, see omni-us/jsonargparse#114 (comment). The relevant documentation is at https://jsonargparse.readthedocs.io/en/latest/#parameter-resolvers.Fixes #11653
Fixes #12697
Fixes #11574
Fixes #8561
Fixes #9887 (comment)
Fixes #8008 (comment)
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃