Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LightningCLI signature parameter resolving for some lightning classes #13283

Merged
merged 8 commits into from
Jun 21, 2022
Merged

Fix LightningCLI signature parameter resolving for some lightning classes #13283

merged 8 commits into from
Jun 21, 2022

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Jun 14, 2022

What does this PR do?

Uses a new version of jsonargparse that extended the support for **kwargs to properly find signature parameters where possible by inspecting the source code, see omni-us/jsonargparse#114 (comment). The relevant documentation is at https://jsonargparse.readthedocs.io/en/latest/#parameter-resolvers.

Fixes #11653
Fixes #12697
Fixes #11574
Fixes #8561
Fixes #9887 (comment)
Fixes #8008 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI labels Jun 14, 2022
@carmocca carmocca added this to the 1.7 milestone Jun 14, 2022
@carmocca carmocca added the community This PR is from the community label Jun 14, 2022
@carmocca carmocca self-assigned this Jun 14, 2022
@mauvilsa mauvilsa changed the title Fix for LightningCLI signature parameter resolving for some lightning classes Fix LightningCLI signature parameter resolving for some lightning classes Jun 14, 2022
@mauvilsa
Copy link
Contributor Author

The jsonargparse version is 4.10.0.dev2 because from feedback here it might make sense to change things before a final release. Though the idea is that this pull request is merged only when 4.10.0 is out.

README.md Outdated Show resolved Hide resolved
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed ready PRs ready to be merged labels Jun 21, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 21, 2022
@carmocca carmocca enabled auto-merge (squash) June 21, 2022 15:18
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jun 21, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jun 21, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 21, 2022
@carmocca carmocca merged commit 6371d7c into Lightning-AI:master Jun 21, 2022
@mauvilsa mauvilsa deleted the cli-ast-params branch June 22, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community feature Is an improvement or enhancement lightningcli pl.cli.LightningCLI ready PRs ready to be merged
Projects
None yet
4 participants