-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to allow custom CheckpointIO
with strategy classes
#13785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
added
bug
Something isn't working
checkpointing
Related to checkpointing
labels
Jul 21, 2022
rohitgr7
requested review from
tchaton,
SeanNaren,
awaelchli,
justusschock,
kaushikb11,
williamFalcon,
Borda and
carmocca
as code owners
July 21, 2022 12:20
need help with mypy |
Codecov Report
@@ Coverage Diff @@
## master #13785 +/- ##
=========================================
+ Coverage 49% 76% +27%
=========================================
Files 327 327
Lines 25457 25540 +83
=========================================
+ Hits 12437 19499 +7062
+ Misses 13020 6041 -6979 |
otaj
reviewed
Jul 21, 2022
kaushikb11
approved these changes
Jul 21, 2022
Thanks! |
otaj
approved these changes
Jul 21, 2022
carmocca
approved these changes
Jul 21, 2022
awaelchli
suggested changes
Jul 22, 2022
awaelchli
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
checkpointing
Related to checkpointing
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Earlier since we initialized accelerator specific
CheckpointIO
in the strategy init, user's don't have an option to plugin customCheckpointIO
due to this:https://github.com/Lightning-AI/lightning/blob/0e5312833fa70fb744f316f3db19c78b38eb9683/src/pytorch_lightning/trainer/connectors/accelerator_connector.py#L348-L352
Found while working on #13658
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @awaelchli @ananthsub @ninginthecloud @rohitgr7 @otaj @akihironitta