Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility between compute groups in MetricCollection and prefix/postfix arg #1008

Merged
merged 12 commits into from
May 6, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 5, 2022

What does this PR do?

Fixes #1006

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 5, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1008 (00f381c) into master (d0e14fe) will increase coverage by 1%.
The diff coverage is n/a.

❗ Current head 00f381c differs from pull request most recent head 34b6d03. Consider uploading reports for the commit 34b6d03 to get more accurate results

@@          Coverage Diff           @@
##           master   #1008   +/-   ##
======================================
+ Coverage      94%     95%   +1%     
======================================
  Files         180     180           
  Lines        7666    7668    +2     
======================================
+ Hits         7231    7274   +43     
+ Misses        435     394   -41     

@mergify mergify bot added the ready label May 5, 2022
@Borda Borda enabled auto-merge (squash) May 5, 2022 11:03
@mergify mergify bot added the has conflicts label May 5, 2022
@mergify mergify bot removed the has conflicts label May 5, 2022
@Borda Borda modified the milestones: v0.9, v0.8 May 5, 2022
@SkafteNicki SkafteNicki modified the milestones: v0.8, v0.9 May 5, 2022
@Borda Borda disabled auto-merge May 6, 2022 04:36
@Borda Borda merged commit 06fdb04 into master May 6, 2022
@Borda Borda deleted the bugfix/compute_groups_prefix_postfix branch May 6, 2022 04:37
Borda pushed a commit that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError while updating MetricCollection with prefix/postfix.
3 participants