Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed non-empty state dict for a few metrics #1012

Merged
merged 14 commits into from
May 7, 2022
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 5, 2022

What does this PR do?

Fixes #1010

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 5, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #1012 (1d9bc36) into master (65ea713) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1012   +/-   ##
======================================
- Coverage      95%     95%   -0%     
======================================
  Files         180     180           
  Lines        7668    7666    -2     
======================================
- Hits         7278    7276    -2     
  Misses        390     390           

@Borda Borda modified the milestones: v0.9, v0.8 May 5, 2022
@Borda Borda enabled auto-merge (squash) May 5, 2022 11:06
@SkafteNicki SkafteNicki modified the milestones: v0.8, v0.9 May 5, 2022
@Borda
Copy link
Member

Borda commented May 6, 2022

@SkafteNicki seems like something went wrong... :/

@SkafteNicki SkafteNicki changed the title Fixed non-empty state dict for calibration error Fixed non-empty state dict for a few metrics May 7, 2022
@mergify mergify bot added the ready label May 7, 2022
@Borda Borda merged commit d134d35 into master May 7, 2022
@Borda Borda deleted the bugfix/non_empty_state_dict branch May 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CalibrationError bin_boundaries added to state_dict
3 participants